Rebuild after release - fix #3118 #3120
Conversation
|
Hi, I’m Jit, a friendly security platform designed to help developers build secure applications from day zero with an MVS (Minimal viable security) mindset. In case there are security findings, they will be communicated to you as a comment inside the PR. Hope you’ll enjoy using Jit. Questions? Comments? Want to learn more? Get in touch with us. |
.github/workflows/release.yml
Outdated
| NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }} | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
| # Rebuild packages after version bump to ensure dist/package.json is updated |
There was a problem hiding this comment.
Hi :) Isn't the package then already on the NPM registry with the previous npm run releases step?
There was a problem hiding this comment.
You are absoluty right! Sorry my fault. I think another solution to fix this error can be add an Hook in release-it.json.
Something like this
"hooks": {
"before:release": "npm run build"
}
What do you think about this solution?
There was a problem hiding this comment.
I'm not very familiar with these hooks but it sounds reasonable to me.
There was a problem hiding this comment.
I've update the hook. Feel free to merge it if you consider it a valid solution.
Thank you for your patience.
2 participants
Description
wget https://registry.npmjs.org/@redis/client/-/client-5.9.0.tgz
mkdir client-5.9.0
tar -xzvf client-5.9.0.tgz -C client-5.9.0
grep "version" client-5.9.0/package.json # "version": "5.9.0",
but inside the dist/
grep "version" client-5.9.0/dist/package.json # "version": "5.9.0-beta
The release workflow has a timing issue where:
The build process (npm run build) runs before the version bump
This creates the dist/package.json with the beta version (5.9.0-beta.3)
Then release-it updates the source package.json to the final version (5.9.0)
But the dist/package.json is never updated, so it still contains the beta version
The Solution:
The release workflow needs to rebuild the packages after the version bump but before publishing to npm.
Checklist
npm testpass with this change (including linting)?